-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodes metadata JSON ouput #162
Conversation
26f290a
to
b0194e0
Compare
b0194e0
to
2d46adc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could maybe see status
and platforms
being a little bit useful in some cases. If the goal is to handle the cases with multiple nodes(not very common in CI) then maybe we could just combine the values for these fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could maybe see
status
andplatforms
being a little bit useful in some cases. If the goal is to handle the cases with multiple nodes(not very common in CI) then maybe we could just combine the values for these fields?
Agreed, especially makes sense for platforms
, I like the idea of merging each node's together for this if we can.
This would not give the expected result as we can define preferred platforms even if those are not supported on specified nodes:
For example here
But I define the following ones as preferred: -
name: Set up Docker Buildx
uses: crazy-max/docker-setup-buildx-action@append
with:
driver: remote
endpoint: docker-container://buildx_buildkit_${{ steps.builder.outputs.name }}0
append: |
- name: aws_graviton2
endpoint: tcp://${{ secrets.AWS_ARM64_HOST }}:1234
platforms: darwin/arm64,linux/arm64,linux/arm/v5,linux/arm/v6,linux/arm/v7,windows/arm64
- name: linuxone_s390x
endpoint: tcp://${{ secrets.LINUXONE_S390X_HOST }}:1234
platforms: linux/s390x See #165 and https://github.com/crazy-max/docker-setup-buildx-action/blob/append/docs/advanced/append-nodes.md about the |
2d46adc
to
6a6597f
Compare
As discussed keep |
78c8b9a
to
8af1ec8
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
8af1ec8
to
ec8fe6a
Compare
At the moment
endpoint
,status
,flags
andplatforms
outputs are only return for the very first note being registered for the builder.This PR adds a new output
nodes
that returns metadata JSON of all registered nodes and also adds new fields available since Buildx 0.9:This change is primarily for future support of appending nodes to a builder, so the output is relevant.
endpoint
,status
,flags
andplatforms
outputs are deprecated and will be removed in next major release.