skip setting buildkitd flags and config for remote driver #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
reviewed
Sep 16, 2022
| @@ -63,7 +63,7 @@ async function run(): Promise<void> { | |||
| await context.asyncForEach(inputs.driverOpts, async driverOpt => { | |||
| createArgs.push('--driver-opt', driverOpt); | |||
| }); | |||
| if (inputs.buildkitdFlags) { | |||
| if (inputs.driver != 'remote' && inputs.buildkitdFlags) { | |||
There was a problem hiding this comment.
We need the same logic below for config as well I think - see driver/remote/factory.go.
There was a problem hiding this comment.
Have not done it for config because it doesn't have a default value like buildkitdFlags but maybe we should just skip for it too I'm not sure.
There was a problem hiding this comment.
Ok actually will be confusing if we do for one but not the other. Should be good now.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-remote
branch
from
fd991d1
to
798ed00
Compare
crazy-max
changed the title
jedevc
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildkitd-flags is not supported by the remote driver.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com