Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused about the usage of 'raw' #154

Closed
LinuxSuRen opened this issue Dec 6, 2021 · 5 comments · Fixed by #155
Closed

Confused about the usage of 'raw' #154

LinuxSuRen opened this issue Dec 6, 2021 · 5 comments · Fixed by #155
Labels

Comments

@LinuxSuRen
Copy link

I feel pretty confused about the usage of raw. According to the explanation, users always get the actual tag name. But it has different results for a release and pre-release.

I'm wondering if it's possible to let it have the same behavior.

* `raw` ; the actual tag

| Git tag            | Pattern                                                  | Output               |
|--------------------|----------------------------------------------------------|----------------------|
| `v1.2.3`           | `{{raw}}`                                                | `v1.2.3`             |
| `v2.0.8-beta.67`   | `{{raw}}`                                                | `2.0.8-beta.67`*     |

I already read the following explanation. But I cannot understand why a pre-release version should not have the prefix v.

> *Pre-release (rc, beta, alpha) will only extend `{{version}}` as tag because they are updated frequently,
> and contain many breaking changes that are (by the author's design) not yet fit for public consumption.
LinuxSuRen added a commit to LinuxSuRen/ks-devops that referenced this issue Dec 6, 2021
@crazy-max
Copy link
Member

@LinuxSuRen Good point, raw should always return the actual tag, even for a pre-release. Will fix that.

@crazy-max
Copy link
Member

@LinuxSuRen #155 should fix this issue. You can try with crazy-max/docker-metadata-action@prerelease-raw.

ks-ci-bot pushed a commit to ks-ci-bot/ks-devops that referenced this issue Dec 6, 2021
@crazy-max
Copy link
Member

@LinuxSuRen Looks like a typo: type=semver,pattern=pattern={{raw}} > type=semver,pattern={{raw}}

@LinuxSuRen
Copy link
Author

My bad. It works well. Thanks for your quick fixing. Great job!

libcgr added a commit to libcgr/bthjh that referenced this issue Apr 24, 2022
jhammonsa added a commit to jhammonsa/ed33 that referenced this issue Apr 26, 2022
husniababaeva3cw6f added a commit to husniababaeva3cw6f/jeffersonoh7 that referenced this issue Apr 27, 2022
Tativega7sl5k added a commit to Tativega7sl5k/rutvik95r that referenced this issue Oct 7, 2022
joseblanchard81 added a commit to joseblanchard81/kubernetes-devops that referenced this issue Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants