Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AWS credentials #21

Merged
merged 1 commit into from Oct 20, 2020
Merged

Handle AWS credentials #21

merged 1 commit into from Oct 20, 2020

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 20, 2020

Fixes #19
Fixes #20

Allows to use aws-actions/configure-aws-credentials with our action for ECR registries. An example has been added in the README:

name: ci

on:
  push:
    branches: master

jobs:
  login:
    runs-on: ubuntu-latest
    steps:
      -
        name: Configure AWS Credentials
        uses: aws-actions/configure-aws-credentials@v1
        with:
          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
          aws-region: <region>
      -
        name: Login to ECR
        uses: docker/login-action@v1
        with:
          registry: <aws-account-number>.dkr.ecr.<region>.amazonaws.com

Has been tested with AWS CLI v2:

image

And v1:

image

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit adb7347 into docker:master Oct 20, 2020
@crazy-max crazy-max deleted the handle-aws-env branch October 20, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants