Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0 backport] builder: define GetRemotes for the worker #44944

Merged
merged 1 commit into from Feb 8, 2023
Merged

[23.0 backport] builder: define GetRemotes for the worker #44944

merged 1 commit into from Feb 8, 2023

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 7, 2023 •
edited

The function signature has changed since v0.10.

(cherry picked from commit 335907d)

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 23.0.1 milestone Feb 7, 2023
@thaJeztah
Copy link
Member Author

Kept this in draft for now, pending #44920 (comment) (in case we want to fix the commit message)

@thaJeztah
Copy link
Member Author

Failure on Windows-2022 https://github.com/moby/moby/actions/runs/4114098814/jobs/7101259444 in TestTopWindowsCoreProcesses. Looks like a flake, but posting here in case it'll happen again.

=== Failed
=== FAIL: github.com/docker/docker/integration-cli TestDockerCLITopSuite/TestTopWindowsCoreProcesses (15.63s)
    check_test.go:359: assertion failed: error is not nil: Error response from daemon: Could not kill running container 24ce24434e62d6a16260e0160300c3e2c6aa6d7e4e080c37f61ae794665e7e83, cannot remove - tried to kill container, but did not receive an exit event: failed to remove 24ce24434e62d6a16260e0160300c3e2c6aa6d7e4e080c37f61ae794665e7e83
    --- FAIL: TestDockerCLITopSuite/TestTopWindowsCoreProcesses (15.63s)

@thaJeztah thaJeztah force-pushed the 23.0_backport_worker_getremotes branch from a5c1351 to 135d6c3 Compare February 7, 2023 22:44
@thaJeztah
Copy link
Member Author

re-did the cherry-pick as #44920 was rebased

we may have to rebase this one after #44952 is merged

@tonistiigi @thaJeztah
builder: define GetRemotes for the worker
e697c93 
The function signature has changed since v0.10.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit 335907d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 23.0_backport_worker_getremotes branch from 135d6c3 to e697c93 Compare February 8, 2023 00:01
@thaJeztah thaJeztah marked this pull request as ready for review February 8, 2023 00:03
@thaJeztah
Copy link
Member Author

Rebased; this should be ready for review ./cc @neersighted @tonistiigi

@neersighted neersighted merged commit 77f3d31 into moby:23.0 Feb 8, 2023
@thaJeztah thaJeztah deleted the 23.0_backport_worker_getremotes branch February 8, 2023 15:47
@apach301 apach301 mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@neersighted neersighted neersighted approved these changes

Assignees
No one assigned
Labels
area/builder/buildkit Issues affecting buildkit area/builder kind/bugfix PR's that fix bugs status/2-code-review
Projects
None yet
Milestone
23.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thaJeztah @tonistiigi @neersighted