[20.10 backport] integration-cli: Fix hanging TestLogsFollowGoroutines* #44765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd.Wait is called twice from different goroutines which can cause the test to hang completely. Fix by calling Wait only once and sending its return value over a channel. In TestLogsFollowGoroutinesWithStdout also added additional closes and process kills to ensure that we don't leak anything in case test returns early because of failed test assertion. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit deb4910)
|
yay, green! (was hitting the jackpot on flaky tests on this PR 😞) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix TestLogsFollowGoroutinesWithStdout and TestLogsFollowGoroutinesNoOutput hanging randomly
- How I did it
cmd.Wait is called twice from different goroutines which can cause the test to hang completely. Fix by calling Wait only once and sending its return value over a channel.
In
TestLogsFollowGoroutinesWithStdoutalso added additional closes and process kills to ensure that we don't leak anything in case test returns early because of failed test assertion.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)