[20.10 backport] hack/make: Don't add -buildmode=pie with -race #44755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to add `-race` to the BUILDFLAGS without making the build fail with error: "-buildmode=pie not supported when -race is enabled" Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of:
This wasn't a clean cherry-pick due lack of #44546.
- What I did
Don't add
-buildmode=piewhen BUILDFLAGS has-raceflag.- How to verify it
make TEST_FILTER='TestLogsFollowGoroutinesWithStdout' BUILDFLAGS='-race' test-integrationshould run TestLogsFollowGoroutinesWithStdout integration test with race detector instead of failing with:
-buildmode=pie not supported when -race is enabled- Description for the changelog