New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.10] vendor: github.com/moby/buildkit eeb7b65ab7d651770a5ec52a06ea7c96eb97a249 (v0.8 branch) #44339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crazy-max looks like some additional packages have to be pulled into vendor;
|
Ahhh indeed I was still in the go modules world my bad. |
I think usually it adds them with |
85f6424
to
9038eae
Compare
Yes was a new one |
Failures will be fixed once #44340 is merged |
Almost green now; wondering if it would be newline or whitespace changes. Let me try to run a vendor on this branch;
|
ah!
|
…7c96eb97a249 (v0.8 branch) Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
9038eae
to
e83e465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all green now, thanks!
LGTM
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)