Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.10 backport] fix local context #44109

Merged
merged 1 commit into from Sep 8, 2022

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Sep 7, 2022

thaJeztah
thaJeztah previously approved these changes Sep 7, 2022
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah dismissed their stale review September 7, 2022 18:01

Looks like build is failing

@thaJeztah

This comment was marked as resolved.

The wrapper sets the default namespace in the context if none is
provided, this is needed because we are calling these services directly
and not trough GRPC that has an interceptor to set the default namespace
to all calls.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
(cherry picked from commit 8789066)
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@corhere @cpuguy83 PTAL

@cpuguy83 cpuguy83 merged commit d348775 into moby:20.10 Sep 8, 2022
@thaJeztah thaJeztah deleted the 20.10-fix-local-context branch September 8, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants