Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.10 backport] info: unset cgroup-related fields when CgroupDriver == none #43004

Merged
merged 1 commit into from Nov 18, 2021

Conversation

AkihiroSuda
Copy link
Member

Cherry-pick #42152 (clean)


Fix #42151

- What I did
unset cgroup-related fields when CgroupDriver == none

- How I did it
Modified `daemon/info_unix.goP

- How to verify it

  • Boot the host with cgroup v1
  • dockerd-rootless-setuptool.sh install
  • docker info --format {{ json. }}
{
...
  "MemoryLimit": false,
  "SwapLimit": false,
  "KernelMemory": false,
  "KernelMemoryTCP": false,
  "CpuCfsPeriod": false,
  "CpuCfsQuota": false,
  "CPUShares": false,
  "CPUSet": false,
  "PidsLimit": false,
...
  "CgroupDriver": "none",
...
}

- Description for the changelog

info: unset cgroup-related fields when CgroupDriver == none

- A picture of a cute animal (not mandatory but encouraged)

馃惂

Fix issue 42151

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 039e967)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@thaJeztah thaJeztah added this to the 20.10.11 milestone Nov 11, 2021
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 847da18 into moby:20.10 Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants