Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out requests to avoid LGPL dependency #2837

Closed
ashb opened this issue May 11, 2021 · 2 comments
Closed

Swap out requests to avoid LGPL dependency #2837

ashb opened this issue May 11, 2021 · 2 comments

Comments

@ashb
Copy link

ashb commented May 11, 2021

This library depends upon requests, and while requests itself is Apache 2 licensed, it depends upon chardet which is LGPL'd.

This leads to confusing licensing situations for projects using this python docker client, and it is the view of the Apache Software Foundation that any LGPL dep places some restrictions on the downstream projects, and thus has to be avoided.

See psf/requests#5797 for the latest attempt to change the dependency upstream (which at the time of writing appears to be a Wont Fix, so I closed the PR)

So: I would like to propose that requests is switched out to httpx library -- it is broadly API compatible with requests.

I am happy to attempt this PR, but first I wanted to raise the issue and see if a PR will be accepted!

@feliperuhland
Copy link
Contributor

That would be nice!

@ashb
Copy link
Author

ashb commented Mar 31, 2022

Requests no longer pulls in a LGPL'd module, so we can close this.

@ashb ashb closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants