Add service capability #2809
Merged
Add service capability #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile and `docker/constants.py` were with old versions, so I updated them to the current one Signed-off-by: Felipe Ruhland <felipe.ruhland@gmail.com>
ContainerSpec
Docker Engine v1.41 added `CapAdd` and `CapDrop` as part of the
ContainerSpec, and `docker-py` should do the same.
```
GET /services now returns CapAdd and CapDrop as part of the ContainerSpec.
GET /services/{id} now returns CapAdd and CapDrop as part of the ContainerSpec.
POST /services/create now accepts CapAdd and CapDrop as part of the ContainerSpec.
POST /services/{id}/update now accepts CapAdd and CapDrop as part of the ContainerSpec.
GET /tasks now returns CapAdd and CapDrop as part of the ContainerSpec.
GET /tasks/{id} now returns CapAdd and CapDrop as part of the ContainerSpec.
```
I added capabilities on docstrings, `service.create` init method and
create tests for that.
That change was mention in issue docker#2802.
Signed-off-by: Felipe Ruhland <felipe.ruhland@gmail.com>
|
Is there any update on this? It would be really nice to have this merged. |
fopina
approved these changes
Aug 2, 2021
|
As PRs are not quickly merged into this project, if anyone else wants to use this without using a complete fork of docker-py (as it could miss update/fixes in main package), I'm currently using the contents of this PR with monkey patching Thanks @feliperuhland 🎊 the changes work pretty well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContainerSpec
Docker Engine v1.41 added
CapAddandCapDropas part of theContainerSpec, and
docker-pyshould do the same.I added capabilities on docstrings,
service.createinit method andcreate tests for that.
That change was mention in issue #2802.