Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release target with checksums #237

Merged
merged 3 commits into from Aug 28, 2022
Merged

Release target with checksums #237

merged 3 commits into from Aug 28, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 27, 2022

Merge release targets in Makefile to a single one called release. Also create checksums and update build workflow to publish artifacts to GitHub Release on push tag.

Also adds extra commit to remove CHANGELOG as it's outdated and now part of GitHub Releases.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #237 (d4880de) into master (da1d534) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   55.25%   55.25%           
=======================================
  Files           9        9           
  Lines         666      666           
=======================================
  Hits          368      368           
  Misses        255      255           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hack/release Outdated Show resolved Hide resolved
hack/git-meta Outdated Show resolved Hide resolved
hack/release Outdated Show resolved Hide resolved
hack/release Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
hack/release Outdated Show resolved Hide resolved
hack/release Outdated Show resolved Hide resolved
credentials/version.go Outdated Show resolved Hide resolved
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last nit, but otherwise looks good

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 7c04fb1 into docker:master Aug 28, 2022
@crazy-max crazy-max deleted the release branch August 28, 2022 20:16
@thaJeztah
Copy link
Member

One difference with the previous releases is that previously we used a tgz to bundle the binary; advantage of that was that;

  • after extracting, the binary has the right name
  • and it looks like it has the right permissions (executable)
ls -la docker-credential-*
-rw-r--r-x 1 root root 2818053 Jun  7  2021 docker-credential-pass
-rw-r--r-- 1 root root 1781760 Aug 29 13:26 docker-credential-pass-v0.7.0-beta.1.linux-amd64
-rwxr-xr-x 1 root root 2495464 Jun  7  2021 docker-credential-secretservice
-rw-r--r-- 1 root root 1578552 Aug 29 13:32 docker-credential-secretservice-v0.7.0-beta.1.linux-amd64

I wasn't sure it the old ones were dynamically linked, but looks like pass static, but secretservice is dynamic (both previous release and new one);

ldd docker-credential-pass
	not a dynamic executable
ldd docker-credential-pass-v0.7.0-beta.1.linux-amd64
	not a dynamic executable

On debian:bullseye;

ldd docker-credential-secretservice
	linux-vdso.so.1 (0x00007ffd5b7da000)
	libsecret-1.so.0 => not found
	libgobject-2.0.so.0 => not found
	libglib-2.0.so.0 => not found
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f63c677e000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f63c65b9000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f63c67a4000)
ldd docker-credential-secretservice-v0.7.0-beta.1.linux-amd64
	linux-vdso.so.1 (0x00007ffcf137e000)
	libsecret-1.so.0 => not found
	libgio-2.0.so.0 => not found
	libgobject-2.0.so.0 => not found
	libglib-2.0.so.0 => not found
	libintl.so.8 => not found
	libc.musl-x86_64.so.1 => not found

On debian:buster;

ldd docker-credential-secretservice
	linux-vdso.so.1 (0x00007ffc289d4000)
	libsecret-1.so.0 => not found
	libgobject-2.0.so.0 => not found
	libglib-2.0.so.0 => not found
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f113bbbc000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f113b9fc000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f113bbe1000)

ldd docker-credential-secretservice-v0.7.0-beta.1.linux-amd64
	linux-vdso.so.1 (0x00007ffeff9f1000)
	libsecret-1.so.0 => not found
	libgio-2.0.so.0 => not found
	libgobject-2.0.so.0 => not found
	libglib-2.0.so.0 => not found
	libintl.so.8 => not found
	libc.musl-x86_64.so.1 => not found

There is a difference in both though on what it's linked against; what distro and libc does it require?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants