Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of privileged attribut in service.build section #10112

Merged
merged 1 commit into from Dec 23, 2022

Conversation

glours
Copy link
Contributor

@glours glours commented Dec 21, 2022

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

What I did
Add support of service.build.privileged attribut recently added in Compose Specification

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours force-pushed the add-build-privileged branch 3 times, most recently from 73bbb5a to 5f6660c Compare December 21, 2022 20:40
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 73.89% // Head: 73.89% // No change to project coverage 👍

Coverage data is based on head (001f0ff) compared to base (0307c16).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10112   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files           2        2           
  Lines         272      272           
=======================================
  Hits          201      201           
  Misses         60       60           
  Partials       11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours glours marked this pull request as ready for review December 21, 2022 21:33
@glours glours requested review from a team, nicksieger, ndeloof, StefanScherer, ulyssessouza, milas and laurazard and removed request for a team December 21, 2022 21:34
@glours glours self-assigned this Dec 21, 2022
@ndeloof ndeloof merged commit fd353ff into docker:v2 Dec 23, 2022
@glours glours deleted the add-build-privileged branch January 11, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants