don't fail logs when driver:none is set
#10107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
ndeloof
force-pushed
the
logging_driver_none
branch
2 times, most recently
from
5ed4bfc
to
b6e4920
Compare
Codecov ReportBase: 76.98% // Head: 75.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10107 +/- ##
==========================================
- Coverage 76.98% 75.79% -1.20%
==========================================
Files 2 2
Lines 252 252
==========================================
- Hits 194 191 -3
- Misses 51 53 +2
- Partials 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
force-pushed
the
logging_driver_none
branch
2 times, most recently
from
c1c162e
to
7b4d94a
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
logging_driver_none
branch
from
7b4d94a
to
22d2e83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
detect engine response requesting container logs as
ErrNotImplementedwhen logging driver is configured tonone. This should not fail the command, just show a warningbonus:
logContainersto collect logs after last watch event, so we don't get previous logs repeated after a container restart.Restartingattribute (not sure why we didn't used this before?)logscan now detect container will not restart and then exits--followRelated issue
fixes: #9030
(not mandatory) A picture of a cute animal, if possible in relation to what you did
