Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't assume os.Stdout and rely on dockerCLI.streams #10082

Merged
merged 1 commit into from Dec 20, 2022
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 15, 2022

What I did
avoid use of os.Stdout and prefer dockerCli.Out()

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 76.98% // Head: 76.98% // No change to project coverage 👍

Coverage data is based on head (e170a3d) compared to base (9d12eec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10082   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files           2        2           
  Lines         252      252           
=======================================
  Hits          194      194           
  Misses         51       51           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof force-pushed the stdout branch 3 times, most recently from 72f4ab2 to 1f603f7 Compare December 15, 2022 10:53
@ndeloof ndeloof requested review from nicksieger, milas, ulyssessouza and glours and removed request for nicksieger and milas December 15, 2022 11:35
Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

cmd/compose/compose.go Outdated Show resolved Hide resolved
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 24f8327 into docker:v2 Dec 20, 2022
@ndeloof ndeloof deleted the stdout branch December 20, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants