Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker engine API to apply fix of CVE-2022-39253 #9934

Merged
merged 1 commit into from Oct 21, 2022

Conversation

glours
Copy link
Contributor

@glours glours commented Oct 21, 2022

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

What I did
Bump version of Docker engine dependency

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

@glours glours requested review from a team, nicksieger, ndeloof, StefanScherer, ulyssessouza, milas, laurazard and thaJeztah and removed request for a team October 21, 2022 07:36
@glours glours self-assigned this Oct 21, 2022
@glours glours added the dependencies Pull requests that update a dependency file label Oct 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Base: 75.86% // Head: 74.56% // Decreases project coverage by -1.29% ⚠️

Coverage data is based on head (197c169) compared to base (b37a6c7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #9934      +/-   ##
==========================================
- Coverage   75.86%   74.56%   -1.30%     
==========================================
  Files           2        2              
  Lines         232      232              
==========================================
- Hits          176      173       -3     
- Misses         49       51       +2     
- Partials        7        8       +1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 72.55% <0.00%> (-1.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@glours
Copy link
Contributor Author

glours commented Oct 21, 2022

@thaJeztah ptal 🙏 , I want to do a dedicated release with that one

@glours glours marked this pull request as draft October 21, 2022 13:01
@glours glours marked this pull request as ready for review October 21, 2022 14:24
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit e8ea3ad into docker:v2 Oct 21, 2022
@StefanScherer
Copy link
Member

Thank you!!

@glours glours deleted the bump-engine-version branch January 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants