Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PyYAML >= 5 #6619

Closed
GeyseR opened this issue Mar 29, 2019 · 10 comments · Fixed by #6623
Closed

Allow PyYAML >= 5 #6619

GeyseR opened this issue Mar 29, 2019 · 10 comments · Fixed by #6623

Comments

@GeyseR
Copy link

GeyseR commented Mar 29, 2019

The PyYAML team recently released version 5.1 of their lib to properly fix CVE-2017-18342 vulnerability. It would be great to add support for this version in docker-compose.

@ijc
Copy link

ijc commented Mar 29, 2019

Thanks for the suggestion.

According to yaml/pyyaml#265 there some incompatibilities, I'm not sure how much of that affect compose but more importantly I see also there is a suggestion to wait for 5.2 in that thread, due to some known issues with 5.1. I think we probably ought to wait for that (although a PR which contained a convincing rationale as to why compose is not affected might also be acceptable).

@rca
Copy link

rca commented Apr 24, 2019

Because docker-compose is a project dependency in one of my repo's, I have these alerts on the repo. I'm not suggesting these should be the reasons to upgrade, but it is a little concerning that an update is being dragged.

image

image

@stale
Copy link

stale bot commented Oct 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 21, 2019
@GeyseR
Copy link
Author

GeyseR commented Oct 23, 2019

I think the issue is still actual

@stale
Copy link

stale bot commented Oct 23, 2019

This issue has been automatically marked as not stale anymore due to the recent activity.

@stale stale bot removed the stale label Oct 23, 2019
@rca
Copy link

rca commented Oct 23, 2019

Yes, still a problem.

@jdyer09
Copy link

jdyer09 commented Oct 26, 2019

One of my builds has downstream dependencies on this and is completely hosed, what's going on here?

@dorpvom
Copy link

dorpvom commented Nov 6, 2019

This is also interesting since Kali comes pre installed with PyYAML 5.1.2 through dist utils and a dozen packages depending on it. This makes using docker-compose on Kali a bit tricky.

@rca
Copy link

rca commented Nov 6, 2019

Even worse is that the community has deemed the PyYAML version docker-compose points to a security risk and, many months in, Docker has done nothing about it. :(

@gangadhar01a
Copy link

Is there any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants