Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set CPU quota #10100

Merged
merged 1 commit into from Dec 19, 2022
Merged

set CPU quota #10100

merged 1 commit into from Dec 19, 2022

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 19, 2022

What I did
fix set CPU quota on created containers
CPUPercent we used so far only applies to ... windows containers!

Related issue
fixes #10073
(this doesn't fix compose-go to replicate deploy.resources... to cpus)

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 76.98% // Head: 76.98% // No change to project coverage 👍

Coverage data is based on head (d0e95cc) compared to base (1e682a4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10100   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files           2        2           
  Lines         252      252           
=======================================
  Hits          194      194           
  Misses         51       51           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, milas and laurazard and removed request for a team December 19, 2022 14:14
@glours glours merged commit 9d12eec into docker:v2 Dec 19, 2022
@ndeloof ndeloof deleted the cpus branch December 20, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cpu limit
2 participants