test: speed up Cucumber stop test #10032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evidently `ping` doesn't respond to `SIGTERM`, so use `init` to get Tini supervising it. This changes the exit code to 143 since it's not hitting the 10s timeout and getting a `SIGKILL` (137). Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza and
glours
and removed request for
a team
nicksieger
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Evidently
pingdoesn't respond toSIGTERM, so useinitto get Tini supervising it. This changes the exit code to 143 since it's not hitting the 10s timeout and getting aSIGKILL(137).Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
