Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass services list to projectOrName function to add profiles for targeted services #10025

Merged
merged 5 commits into from Nov 30, 2022

Conversation

glours
Copy link
Contributor

@glours glours commented Nov 28, 2022

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

What I did
Pass the list of targeted services to projectOrName to let compose-go parsing add associated profiles and then follow the Compose specification:

A service MUST be ignored by the Compose implementation when none of the listed profiles match the active ones, unless the service is explicitly targeted by a command. In that case its profiles MUST be added to the set of active profiles.

Related issue
fixes #9986

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

@glours glours self-assigned this Nov 28, 2022
@glours glours force-pushed the enable-profies-target-services branch from cdf1be3 to adfd19d Compare November 29, 2022 09:39
@glours glours changed the title pass servics list to projectOrName function to add profiles for targeted services pass services list to projectOrName function to add profiles for targeted services Nov 29, 2022
@glours glours force-pushed the enable-profies-target-services branch 2 times, most recently from 4f27f59 to 9583f68 Compare November 29, 2022 09:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Base: 75.86% // Head: 74.56% // Decreases project coverage by -1.29% ⚠️

Coverage data is based on head (d558bc0) compared to base (ed38fe0).
Patch has no changes to coverable lines.

❗ Current head d558bc0 differs from pull request most recent head 8e1eea2. Consider uploading reports for the commit 8e1eea2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10025      +/-   ##
==========================================
- Coverage   75.86%   74.56%   -1.30%     
==========================================
  Files           2        2              
  Lines         232      232              
==========================================
- Hits          176      173       -3     
- Misses         49       51       +2     
- Partials        7        8       +1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 72.55% <0.00%> (-1.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…eted services

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the enable-profies-target-services branch from d558bc0 to 8e1eea2 Compare November 30, 2022 10:53
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the enable-profies-target-services branch from 8e1eea2 to a4b2285 Compare November 30, 2022 10:59
@glours glours marked this pull request as ready for review November 30, 2022 11:11
@glours glours requested review from a team, nicksieger, ndeloof, StefanScherer, ulyssessouza, milas and laurazard and removed request for a team November 30, 2022 11:11
@ndeloof ndeloof merged commit 707d55c into docker:v2 Nov 30, 2022
@glours glours deleted the enable-profies-target-services branch January 11, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants