-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19.03 backport] CI and testing improvements #2048
Merged
andrewhsu
merged 7 commits into
docker:19.03
from
thaJeztah:19.03_backport_ci_improvements
Aug 22, 2019
Merged
[19.03 backport] CI and testing improvements #2048
andrewhsu
merged 7 commits into
docker:19.03
from
thaJeztah:19.03_backport_ci_improvements
Aug 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 53fc63a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
18.03 has reached EOL; let's use a more current version in CI Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 8b19c1d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 82e0180) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 9a6519d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit ae58e35) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 893db86) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These changes were made as part of the `docker engine` feature in commit fd2f1b3, but later reverted in f250152 and b7ec4a4 These lines were forgotten to be removed, and should no longer be needed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit de01e72) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@andrewhsu @tiborvass PTAL |
Codecov Report
@@ Coverage Diff @@
## 19.03 #2048 +/- ##
=======================================
Coverage 56.75% 56.75%
=======================================
Files 311 311
Lines 21820 21820
=======================================
Hits 12383 12383
Misses 8522 8522
Partials 915 915 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 19.03 #2048 +/- ##
=======================================
Coverage 56.75% 56.75%
=======================================
Files 311 311
Lines 21820 21820
=======================================
Hits 12383 12383
Misses 8522 8522
Partials 915 915 |
andrewhsu
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of:
Dockerfile: use GO_VERSION build-arg for overriding Go version #2008 Dockerfile: use GO_VERSION build-arg for overriding Go versionDisable TLS for e2e docker-in-docker daemon #2020 Disable TLS for e2e docker-in-docker daemon