[19.03 backport] context: produce consistent output on context create.
#1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor `RunCreate` slightly so that all three paths always produce the same output, namely the name of the new context of `stdout` (for scripting) and the success log message on `stderr`. Validate by extending the existing unit tests to always check the output is as expected. Signed-off-by: Ian Campbell <ijc@docker.com> (cherry picked from commit ff44305) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## 19.03 #1985 +/- ##
==========================================
+ Coverage 56.71% 56.72% +<.01%
==========================================
Files 310 310
Lines 21789 21793 +4
==========================================
+ Hits 12357 12361 +4
Misses 8519 8519
Partials 913 913 |
|
@silvin-lubecki PTAL |
|
Merging this one, because currently, no output is produced at all in some cases, e.g.: docker context create --from=default mynewcontext
# no output |
thaJeztah
deleted the
19.03_backport_consistent_output_on_context_create
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1874
Refactor
RunCreateslightly so that all three paths always produce the sameoutput, namely the name of the new context of
stdout(for scripting) and thesuccess log message on
stderr.Validate by extending the existing unit tests to always check the output is as
expected.