Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RISCV64 #643

Closed
qdm12 opened this issue Jun 24, 2021 · 2 comments
Closed

Support RISCV64 #643

qdm12 opened this issue Jun 24, 2021 · 2 comments
Labels
kind/enhancement New feature or request

Comments

@qdm12
Copy link

qdm12 commented Jun 24, 2021

There is the dependency github.com/prometheus/procfs which added support for riscv64 in v0.6.0 (prometheus/procfs@910e685)
Currently trying to build for riscv64:

GOARCH=riscv64 go build  ./cmd/buildx

will fail with

/go/pkg/mod/github.com/prometheus/procfs@v0.1.3/cpuinfo.go:71:9: undefined: parseCPUInfo

buildx probably depends on many dependencies using versions before v0.6.0 so it's more of a long shot than something that can be fixed in a single PR I believe. Although

go get github.com/prometheus/procfs@v0.6.0
go mod tidy

Fixes the build, but probably in a risky-ish way I guess. Not a priority issue at all, but I thought it would be useful to track it.

@AkihiroSuda AkihiroSuda added the kind/enhancement New feature or request label Jun 24, 2021
@tonistiigi
Copy link
Member

Procfs was updated in #565 d40a608#diff-b318e1e6bbcc59892bb6b4298564b051c6f6d5d848878d14aab856509ff0625cR333

Added CI validation in #652

@qdm12
Copy link
Author

qdm12 commented Jun 29, 2021

Ah indeed, sorry for the mistake, I was using the latest release v0.5.1. Any plan to make another release sometime by the way? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants