Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment regarding the support of subdir context #661

Merged
merged 1 commit into from Aug 3, 2022

Conversation

dud225
Copy link
Contributor

@dud225 dud225 commented Aug 3, 2022

No description provided.

@dud225 dud225 requested a review from crazy-max as a code owner August 3, 2022 10:02
@jedevc
Copy link
Contributor

jedevc commented Aug 3, 2022

Not sure if I understand the reason for this 😕

The README already describes that you should use the setup-buildx-action, not sure if we need to call it out again below!

@dud225
Copy link
Contributor Author

dud225 commented Aug 3, 2022

I'm personally used to omit this addittional action because for basic usage the Buildkit embedded within the Docker engine just works fine. I've removed the mention to it.

@crazy-max
Copy link
Member

Thank you for contributing! It appears your commit message is missing a DCO sign-off, causing the DCO check to fail.

We require all commit messages to have a Signed-off-by line with your name and e-mail, which looks something like:

Signed-off-by: YourFirsName YourLastName <yourname@example.org>

There is no need to open a new pull request, but to fix this (and make CI pass), you need to amend the commit(s) in this pull request, and "force push" the amended commit.

You can find some instructions in the output of the DCO check (which can be found in the "checks" tab on this pull request), as well as in the Moby contributing guide.

Steps to do so "roughly" come down to:

  1. Set your name and e-mail in git's configuration:

    git config --global user.name "YourFirstName YourLastName"
    git config --global user.email "yourname@example.org"
    

    (Make sure to use your real name (not your GitHub username/handle) and e-mail)

  2. Clone your fork locally

  3. Check out the branch associated with this pull request

  4. Sign-off and amend the existing commit(s)

    git commit --amend --no-edit --signoff
    

    If your pull request contains multiple commits, either squash the commits (if needed) or sign-off each individual commit.

  5. Force push your branch to GitHub (using the --force or --force-with-lease flags) to update the pull request.

Sorry for the hassle, and let me know if you need help or more detailed instructions!

Signed-off-by: Hervé Werner <dud225@hotmail.com>
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-max crazy-max merged commit cd5d0b7 into docker:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants