Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated fs.rmdir with fs.rm #657

Merged
merged 1 commit into from Jul 28, 2022
Merged

Replace deprecated fs.rmdir with fs.rm #657

merged 1 commit into from Jul 28, 2022

Conversation

bendrucker
Copy link
Contributor

Fixes the following deprecation warning during cleanup:

(node:7106) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)

https://nodejs.org/api/deprecations.html#DEP0147

@bendrucker
replace deprecated fs.rmdir with fs.rm
988cb09 
Signed-off-by: Ben Drucker <bvdrucker@gmail.com>
crazy-max
crazy-max approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-max crazy-max merged commit 67af6dc into docker:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bendrucker @crazy-max