Netty factory: Close TCP connection when receive TLS close notify #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLS has special TLS Alert message "close_notify". After receiving such packet any conversation should be immediately stopped. Some TLS implementations (OpenSSL for example) closes underlying TCP connection when TLS connection being closed, some (Docker SSL server and docker-java before current commit) does not close. AttachContainerCmd executes `onComplete` callback only when TCP connection closes, so without this patch `onComplete` called after a long timeout, with this patch it called when container exits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS has special TLS Alert message "close_notify". After receiving such packet any conversation
should be immediately stopped. Some TLS implementations (OpenSSL for example) closes underlying TCP connection when TLS connection being closed, some (Docker SSL server and docker-java before current commit) does not close. AttachContainerCmd executes
onCompletecallback only when TCP connection closes, so without this patchonCompletecalled after a long timeout, with this patch it called when container exits.This change is