You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @movchan74 ,
Let me try to answer the 2 questions:
If we want to add extend to DocVec. We are not so sure about this, DocVec is much more planned to be static in terms of size, and will be complex to provide a coherent list-like behavior. In past versions we tried to fit every pattern in a single type of object, and we now decided to clarify the interfaces. We believe it is better to do DocVec.to_doc_list, do the extension and then convert back. However, we welcome you to join our [discord channel](https://discord.gg/xBTCDPFs) to discuss this or any other design choices.
Here we want to be cautious about how we integrate an extended method on DocVec because extending on a DocVec will be slower that on a DocList (because of underlying implementation)
The way I see it we could either have:
1- extend as a method of DocVec that add the new DocVec to self
2- cat function like in torch/numpy that will fuse to DocVec into one
1 is more coherent with DocList. 2 is more intuitive and gives more insight into what is happening under the hood.
Our concern is that we wanted in purpose not to have consistency with DocList so that it is clear that they are different things and behave differently.
We have the impression that adding appends and extends support people will expect list-like behavior which we cannot ensure
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Discussion coming from #1489 .
@movchan74 asked:
@JoanFM replied:
@samsja commented:
@movchan74 replied:
@JoanFM replied:
Beta Was this translation helpful? Give feedback.
All reactions