Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Ord trait to GenericFraction #74

Merged
merged 3 commits into from Dec 3, 2022
Merged

added Ord trait to GenericFraction #74

merged 3 commits into from Dec 3, 2022

Conversation

DrAlta
Copy link
Contributor

@DrAlta DrAlta commented Dec 2, 2022

I made it so the NaN is less than everything else.

I needed this, so I can use fractions as the key to a BTreeMap.

@dnsl48
Copy link
Owner

dnsl48 commented Dec 3, 2022

Yep, looks good, thank you for the contribution!
The patch itself is looking alright, but there are some formatting issues, a couple of semantic things that clippy has picked up and perhaps a couple of tests are worth writing. We should be able to do this after this is merged, no worries 👍

@dnsl48 dnsl48 merged commit 5b3ea44 into dnsl48:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants