Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error responses for registerDomain endpoint action #140

Open
DXTimer opened this issue May 5, 2023 · 2 comments
Open

Handle error responses for registerDomain endpoint action #140

DXTimer opened this issue May 5, 2023 · 2 comments
Labels
bug Code defect or incorrect behavior

Comments

@DXTimer
Copy link
Contributor

DXTimer commented May 5, 2023

What is the problem?

Currently, if the endpoint returns a 400 error response it is not able to marshal the response.

Error:

json: cannot unmarshal string into Go struct field ErrorResponse.errors of type []string
@DXTimer DXTimer added the bug Code defect or incorrect behavior label May 5, 2023
@ghost ghost changed the title Handle error responses for regiterDomain endpoint action Handle error responses for registerDomain endpoint action Aug 10, 2023
@ghost ghost assigned DXTimer Oct 24, 2023
@sushant102004
Copy link

Can I take this issue?

@weppos
Copy link
Member

weppos commented Jan 2, 2024

Can I take this issue?

Hi @sushant102004, if you want to submit a PR we will be happy to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code defect or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@weppos @DXTimer @sushant102004 and others