Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gopkg.in/yaml.v2 dependency due to CVE-2019-11254 #60

Closed
Blesmol opened this issue Jun 7, 2021 · 3 comments
Closed

Upgrade gopkg.in/yaml.v2 dependency due to CVE-2019-11254 #60

Blesmol opened this issue Jun 7, 2021 · 3 comments

Comments

@Blesmol
Copy link
Contributor

Blesmol commented Jun 7, 2021

Hi,

I would kindly like to ask whether you could upgrade your dependency to module gopkg.in/yaml.v2 from v2.2.1 to v2.2.8?

There were improvements to the performance in specific cases, fixed by go-yaml/yaml#555, and versions of yaml.v2 without that fix even have a CVE entry, although the description there is a little bit confusing, as it is mainly talking about the K8S API server...

Still, updating from v2.2.1 to v2.2.8 should neither introduce compatibility issues nor other problems. I also did the update locally, and the test suite ran fine. I can also provide a PR that updates the go.mod file and contents of the vendor dir if you want.

Thanks!

@dnaeon
Copy link
Owner

dnaeon commented Jun 7, 2021

Hey @Blesmol ,

Please feel free to submit a PR. I'd happy to review and merge it.

Thanks!

@Blesmol
Copy link
Contributor Author

Blesmol commented Jun 7, 2021

Hi @dnaeon ,

Thanks! Created new PR #61 for this.

@Blesmol
Copy link
Contributor Author

Blesmol commented Jun 7, 2021

Thanks for merging! :)

@Blesmol Blesmol closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants