Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PySpark Training] Eval results are not saved during training #9626

Open
JoHacksCode opened this issue Oct 4, 2023 · 2 comments
Open

[PySpark Training] Eval results are not saved during training #9626

JoHacksCode opened this issue Oct 4, 2023 · 2 comments

Comments

@JoHacksCode
Copy link

Hello,

I am using the SparkXGBRegressor to train my models, v2.0.0. I've realized that even though they are logged during the training, the evals results are not saved, and cannot be accessed anywhere but in the logs.
This has a big impact, because I wish to use eval_metrics to compare models but cannot do so without the results.

Looking at the code, we can see that the evals_results are saved into a variable that is not used nor saved in the model.

evals_result: Dict[str, Any] = {}

Would it be possible to have a quick fix for this please

@hcho3
Copy link
Collaborator

hcho3 commented Oct 4, 2023

According to #8352, evals_result was not part of the initial PySpark implementation. I am marking this as a feature request.

@wbo4958 @WeichenXu123 How difficult do you think adding evals_result would be for the PySpark interface?

@wbo4958
Copy link
Contributor

wbo4958 commented Nov 17, 2023

Yeah, We can support that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants