Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py-skl] Move feature_weights to constructor. #8087

Open
trivialfis opened this issue Jul 17, 2022 · 0 comments · May be fixed by #9506
Open

[py-skl] Move feature_weights to constructor. #8087

trivialfis opened this issue Jul 17, 2022 · 0 comments · May be fixed by #9506
Labels
type: bug
Projects
PySpark Support

Comments

@trivialfis
Copy link
Member

Similar to feature types, we should move anything that's not strictly related to data to the constructor for the scikit-learn interface. Also, it will fix the pyspark interface:

 WARNING: /home/jiaming/Workspace/XGBoost-dev/xgboost/src/learner.cc:628: 
Parameters: { "feature_weights" } might not be used.

  This could be a false alarm, with some parameters getting used by language bindings but
  then being mistakenly passed down to XGBoost core, or some parameter actually being used
  but getting flagged wrongly here. Please open an issue if you find any such cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
PySpark Support
To Do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Move feature weight to skl parameters. trivialfis/xgboost
1 participant
@trivialfis