Support null value in CUDA array interface. #8486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix for potential null value in array interface. - Fix incorrect check on mask stride.
|
Will add some tests to ensure we have some coverage even without the latest cuDF. |
wphicks
approved these changes
Nov 28, 2022
hcho3
approved these changes
Nov 29, 2022
hcho3
pushed a commit
to hcho3/xgboost
that referenced
this pull request
Nov 30, 2022
* Support null value in CUDA array interface. - Fix for potential null value in array interface. - Fix incorrect check on mask stride. * Simple tests. * Extract mask.
hcho3
added a commit
that referenced
this pull request
Nov 30, 2022
trxcllnt
pushed a commit
to trxcllnt/xgboost
that referenced
this pull request
Dec 5, 2022
* Support null value in CUDA array interface. - Fix for potential null value in array interface. - Fix incorrect check on mask stride. * Simple tests. * Extract mask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is found when running cuDF tests with nightly cuDF (22.12) where the
stridesfor the array interface is set toNONE.