[jvm-packages] [pyspark] Make QDM optional based on cuDF check #8471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeichenXu123
force-pushed
the
qdm-option
branch
from
54c51bb
to
bce3da7
Compare
wbo4958
reviewed
Nov 16, 2022
trivialfis
reviewed
Nov 17, 2022
WeichenXu123
changed the title
use_quantile_dmatrix param and make cuDF optional in PySpark package
|
@trivialfis PR updated ! :) |
WeichenXu123
requested review from
wbo4958,
hcho3 and
trivialfis
and removed request for
wbo4958,
hcho3 and
trivialfis
WeichenXu123
requested review from
hcho3 and
trivialfis
and removed request for
trivialfis and
hcho3
wbo4958
reviewed
Nov 23, 2022
wbo4958
reviewed
Nov 23, 2022
trivialfis
requested changes
Nov 24, 2022
trivialfis
reviewed
Nov 24, 2022
trivialfis
approved these changes
Nov 24, 2022
WeichenXu123
force-pushed
the
qdm-option
branch
from
02d6c62
to
943921c
Compare
WeichenXu123
commented
Nov 24, 2022
Comment on lines
+81
to
+82
| if importlib.util.find_spec("cudf") is None: | ||
| return False |
There was a problem hiding this comment.
This is for avoiding printing importing error if cuDF not installed. (specifically for databricks runtime)
trivialfis
reviewed
Nov 25, 2022
trivialfis
approved these changes
Nov 27, 2022
trivialfis
pushed a commit
to trivialfis/xgboost
that referenced
this pull request
Dec 6, 2022
trivialfis
added a commit
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Weichen Xu weichen.xu@databricks.com
Closes #8467
Closes #8469
If cuDF is installed and using hist / gpu_hist tree method, use QDM, otherwise use DMatrix.