SO_DOMAIN do not support on AIX, using getsockname instead #8437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Nov 8, 2022
|
You can check the result based on cpp unittest |
|
@trivialfis thanks. Can you help me how to build out the testxgboost utility? |
Yes. the domain could be retrieved just after the socket been created by socket() routine. |
|
XGBoost requires googletest to build its c++ tests. |
|
Not sure whether this is a MUST for the PR , as we do not have googletest available on our OS yet :-(. |
trivialfis
approved these changes
Nov 10, 2022
|
BTW, how can we make sure this fix tobe integrated in next release/fixpack ? @trivialfis thanks. |
|
@zheddie We will. |
hcho3
pushed a commit
to hcho3/xgboost
that referenced
this pull request
Nov 30, 2022
Co-authored-by: GavinZhang <zhanggan@cn.ibm.com>
hcho3
added a commit
that referenced
this pull request
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getsockopt do not support SO_DOMAIN on AIX/IBM i . Using the getsockname() instead to get the domain info. thanks.