Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pyspark] Filter out the unsupported train parameters #8355

Merged
merged 1 commit into from Oct 18, 2022
Merged

[pyspark] Filter out the unsupported train parameters #8355

merged 1 commit into from Oct 18, 2022

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Oct 18, 2022

This PR adds paramters {"evals", "evals_result"} to the train unsupported parameters

To close #8352

@wbo4958
Copy link
Contributor Author

wbo4958 commented Oct 18, 2022

@hcho3 @trivialfis please help to trigger the CI and help to review.

trivialfis
trivialfis approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass.

@trivialfis trivialfis merged commit 76f95a6 into dmlc:master Oct 18, 2022
@wbo4958 wbo4958 deleted the eval-result branch October 18, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pyspark] eval_result is not working
2 participants
@wbo4958 @trivialfis