Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid blank lines with federated training #8342

Merged
merged 1 commit into from Oct 14, 2022
Merged

Avoid blank lines with federated training #8342

merged 1 commit into from Oct 14, 2022

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Oct 13, 2022

Right now we use LOG(CONSOLE) << msg to print messages during federated training. But the evaluation callback already puts a newline in the message, resulting in blank lines being printed.

@trivialfis

@trivialfis
Copy link
Member

hmm , is the CI triggered?

@trivialfis trivialfis merged commit 80e10e0 into dmlc:master Oct 14, 2022
@trivialfis trivialfis added this to In progress in 1.7 Roadmap via automation Oct 14, 2022
@trivialfis trivialfis moved this from In progress to Done in 1.7 Roadmap Oct 14, 2022
@rongou rongou deleted the fix-federated-print branch November 18, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
1.7 Roadmap
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rongou @trivialfis