Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require keyword args for data iterator. #8327

Merged
merged 4 commits into from Oct 10, 2022
Merged

Require keyword args for data iterator. #8327

merged 4 commits into from Oct 10, 2022

Conversation

trivialfis
Copy link
Member

Close #8202 .

@trivialfis trivialfis added this to In progress in 1.7 Roadmap via automation Oct 10, 2022
@trivialfis
Copy link
Member Author

Python can raise a TypeError without the wrapper:

TypeError: DataIter._next_wrapper.<locals>.data_handle() takes 1 positional argument but 2 were given

But with the wrapper, the message is more informative.

1.7 Roadmap automation moved this from In progress to Reviewer approved Oct 10, 2022
@trivialfis trivialfis merged commit 5545c49 into dmlc:master Oct 10, 2022
1.7 Roadmap automation moved this from Reviewer approved to Done Oct 10, 2022
@trivialfis trivialfis deleted the require-keyword-args branch October 10, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
1.7 Roadmap
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XGBoost External Memory Version Load SVM File Into DMatrix Error
2 participants
@trivialfis @RAMitchell