Better error message when world size and rank are set as strings #8316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Oct 8, 2022
|
I think it's just a little surprising to a user that even though she has specified the world rank and size, and happen to use strings, we complain about them not being set. Maybe we should enforce the rule that they should be integers? That'll give a more meaningful error message. |
rongou
changed the title
|
@trivialfis please take another look. |
trivialfis
reviewed
Oct 11, 2022
| @@ -40,6 +40,9 @@ class FederatedCommunicatorTest : public ::testing::Test { | |||
| } | |||
|
|
|||
| void TearDown() override { | |||
| while (!server_) { | |||
There was a problem hiding this comment.
This seems odd, could you please share when it helps?
There was a problem hiding this comment.
This was somehow needed to get the create test to work. Seems more trouble than its worth. Removed.
trivialfis
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring the federated communicator, only allow world size and rank to be set as integers, and provide a more meaningful error message when they are set as strings.