[spark] Add validation for param 'early_stopping_rounds' and 'validation_indicator_col' #8250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @trivialfis @wbo4958 Thanks! |
wbo4958
approved these changes
Sep 20, 2022
|
@trivialfis @wbo4958 Ready for merging ! :) |
|
@trivialfis @wbo4958 Ready for merging :) |
trivialfis
approved these changes
Sep 22, 2022
|
Will look into the CI and merge it today. |
|
+1 ed. |
|
Could you please fix the test? |
WeichenXu123
force-pushed
the
val_col_param_validation
branch
from
cef7dee
to
afbd986
Compare
|
CC @trivialfis Tests fixed. Failed CIs are not related. |
trivialfis
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Weichen Xu weichen.xu@databricks.com
Add validation for param 'early_stopping_rounds' and 'validation_indicator_col'