JNI wrapper for the collective communicator #8242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongou
force-pushed
the
jvm-communicator
branch
from
0ba2f3f
to
8312176
Compare
|
Started buildkite. |
trivialfis
reviewed
Sep 16, 2022
|
Added a note about the api being experimental. |
|
Restarted failed tests. |
trivialfis
approved these changes
Sep 19, 2022
|
Looks like Communicator.java is quite the same as Rabit.java. So does Communicator is dedicated to federated learning? Can it be replaced with the existing Rabit? Looks like we need to re-design this part to abstract the common parts. But that can be in a following-up PR. |
|
@wbo4958 yes it's more a less a drop-in replacement for Rabit. My next step is to replace all the rabit calls with communicator, and then delete Rabit.java. These changes don't affect the JVM side in terms of behavior, but are needed since we are changing the c++ code. |
|
@trivialfis can this be merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're probably not going to support federated learning in Spark, but since we'll switch the c++ code to use the communicator interface, this is also needed to keep the java/scala code functioning.