Initial support for IPv6 #8225
Merged
Initial support for IPv6 #8225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The use of |
- Merge rabit socket into XGBoost. - Dask interface support. - Add test to socket. - Add more compatibility code with mysys32, including correct linking and enable most of the system function calls. - Workaround windows includes in tests. dmlc filesystem includes `windows.h`, which conflicts with winsock2.h.
trivialfis
commented
Sep 14, 2022
|
@rongou Would you like to take a look into this? |
rongou
approved these changes
Sep 20, 2022
RAMitchell
reviewed
Sep 21, 2022
There was a problem hiding this comment.
I can't really say much about the implementation as I don't have experience here.
It does seem a bit unusual to me that we are doing this ourselves and not using a library. Would using another framework for communication give us IPv6?
If you are confident with this PR you should go ahead with it.
|
@RAMitchell We used to treat rabit as a separate library. ;-) But as suggested by @rongou , we can switch to something well maintained for allreduce implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the system function calls.
windows.h, whichconflicts with winsock2.h.
Current status:
This PR enables initial support for IPv6 with dask on Linux. Some effort is put into Windows support but we don't support distributed training on Windows in general. As for macos, RABIT allreduce returns error but I don't have a macos device for development or testing.
I ran some basic tasks using dask on GCP debian-based instance with dual stack and verified that IPv6 is indeed used.
#7725 .