Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply dmatrix iteration iterface in PySpark xgboost and support external memory mode #8083

Closed
WeichenXu123 opened this issue Jul 15, 2022 · 7 comments · Fixed by #8284
Closed

Comments

@WeichenXu123
Copy link
Contributor

Apply dmatrix iteration iterface in PySpark xgboost and support external memory mode.

@WeichenXu123
Copy link
Contributor Author

@trivialfis When will you create first PR "Apply dmatrix iteration iterface in PySpark xgboost " ? If you are busy, I can help to create PR. Thank you.

@trivialfis
Copy link
Member

@WeichenXu123 Thank you for the work. Feel free to continue the work on external memory. I just didn't want to have too many conflicts between the implementation of ext memory and the quantile dmatrix. (See the WIP iterator in #8088 ).

@WeichenXu123
Copy link
Contributor Author

@trivialfis To reduce conflicts, I would like to wait #8088 merged first. :)

@trivialfis trivialfis added this to 2.0 TODO in 2.0 Roadmap via automation Sep 22, 2022
@trivialfis
Copy link
Member

I need to apply the quantile dmatrix to spark as well.

@WeichenXu123
Copy link
Contributor Author

I think external memory is useless in most cases.

if memory is not efficient per task, we can increase num_workers param.

@trivialfis
Copy link
Member

I agree. I kept the feature here mostly for experimental support.

@trivialfis
Copy link
Member

But quantile DMatrix can still be used for reducing memory usage without sacrificing performance.

@trivialfis trivialfis removed this from 2.0 TODO in 2.0 Roadmap Sep 28, 2022
@trivialfis trivialfis added this to To do in 1.7 Roadmap via automation Sep 28, 2022
@trivialfis trivialfis moved this from To do to In progress in 1.7 Roadmap Sep 28, 2022
@trivialfis trivialfis moved this from In progress to Reviewer approved in 1.7 Roadmap Oct 12, 2022
1.7 Roadmap automation moved this from Reviewer approved to Done Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants