Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xgboost pyspark integration: User guide doc and tutorials #8082

Merged
merged 7 commits into from Jul 19, 2022
Merged

Xgboost pyspark integration: User guide doc and tutorials #8082

merged 7 commits into from Jul 19, 2022

Conversation

WeichenXu123
Copy link
Contributor

Xgboost pyspark integration: User guide doc and tutorials

@WeichenXu123
Copy link
Contributor Author

CC @trivialfis @wbo4958 Thanks!

@wbo4958
Copy link
Contributor

wbo4958 commented Jul 16, 2022

Overall, LGTM.

@WeichenXu123
Copy link
Contributor Author

Failed test is not related:
tests/python/test_with_dask.py::test_boost_from_prediction[approx]

@WeichenXu123
Copy link
Contributor Author

@wbo4958 Is it good to merge ?

@wbo4958
Copy link
Contributor

wbo4958 commented Jul 19, 2022 •
edited

Yes, I think so, at least LGTM. @trivialfis could you help to review and merge it?

@trivialfis trivialfis merged commit f23cc92 into dmlc:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbo4958 wbo4958 wbo4958 approved these changes

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WeichenXu123 @wbo4958 @trivialfis