Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing categorical value in CPU evaluator. #7948

Merged
merged 3 commits into from May 27, 2022
Merged

Handle missing categorical value in CPU evaluator. #7948

merged 3 commits into from May 27, 2022

Conversation

trivialfis
Copy link
Member

No description provided.

hcho3
hcho3 approved these changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the logic for partition is now cleanly separated from the numerical enumeration. LGTM.

src/tree/hist/evaluate_splits.h Show resolved Hide resolved
@trivialfis trivialfis merged commit bde4f25 into dmlc:master May 27, 2022
@trivialfis trivialfis deleted the cat-cpu-part-missing branch May 27, 2022 06:15
@trivialfis trivialfis added this to 2.0 In Progress in 2.0 Roadmap via automation May 27, 2022
@trivialfis trivialfis mentioned this pull request May 30, 2022
Open
16 tasks
@trivialfis trivialfis moved this from 2.0 In Progress to 2.0 Done in 2.0 Roadmap May 31, 2022
@trivialfis trivialfis removed this from 2.0 Done in 2.0 Roadmap Sep 28, 2022
@trivialfis trivialfis added this to In progress in 1.7 Roadmap via automation Sep 28, 2022
@trivialfis trivialfis moved this from In progress to Done in 1.7 Roadmap Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
1.7 Roadmap
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trivialfis @hcho3