Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce base margin to 2 dim for now. #7455

Merged
merged 1 commit into from Nov 26, 2021
Merged

Reduce base margin to 2 dim for now. #7455

merged 1 commit into from Nov 26, 2021

Conversation

trivialfis
Copy link
Member

Different targets might have a different number of classes, simply adding dim doesn't cut it.

@trivialfis trivialfis mentioned this pull request Nov 20, 2021
Merged
@trivialfis trivialfis merged commit 557ffc4 into dmlc:master Nov 26, 2021
@trivialfis trivialfis deleted the revert-base-margin branch November 26, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trivialfis @RAMitchell