Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add range-based slicing to tensor view. #7453

Merged
merged 13 commits into from Nov 27, 2021
Merged

Add range-based slicing to tensor view. #7453

merged 13 commits into from Nov 27, 2021

Conversation

trivialfis
Copy link
Member

  • Decouple the implementation with xgboost to make it reusable.
  • Add range-based slicing to tensor view.
  • Calculate CContiguous explicitly.
  • Remove span-based iterators.

@trivialfis trivialfis mentioned this pull request Nov 20, 2021
Merged
RAMitchell
RAMitchell approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some use of span here right? So this implementation is still coupled with xgb.

@trivialfis
Copy link
Member Author

Yes, but the span class by itself is quite reusable.

@trivialfis trivialfis merged commit 85cbd32 into dmlc:master Nov 27, 2021
@trivialfis trivialfis deleted the range-slice branch November 27, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trivialfis @RAMitchell