Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for validate parameters when initiate? #739

Closed
yitang opened this issue Jan 12, 2016 · 3 comments
Closed

check for validate parameters when initiate? #739

yitang opened this issue Jan 12, 2016 · 3 comments

Comments

@yitang
Copy link

yitang commented Jan 12, 2016

Hi, thanks for providing this amazing package.

I've been moving from R to Python, and get lost in the different naming for same paramteres. also, I noticed that when initiate a xgboost model, it won't check for validate paramters, for example,

bst = xgb.Booster({'lala':4}) 
cv_res = xgb.cv({'lala':4}, dtrain)

both work fine. And I can't find how the "lala" parameter is used after reading the source code.

Not checking validate parameters leaves a door for user making bugs when move between different xgboost wrappers. Previously I was using the sklearn wrapper and the regularisation parameters is called "learning_rate", and in the xgb.cv, the name is "eta". I didn't aware of this bug until I saw someone else's code and the program has been running for 30 hours...

Yi

@Far0n
Copy link
Contributor

Far0n commented Jan 17, 2016

Hey yitang,

this is a good suggestion.

As a side note: it doesn't matter if u call your param "eta" or "learning_rate" in the python wrapper. It is not documented (at least I'm not aware of), but the core part of xgb just scans the params for known names.

@ivallesp
Copy link
Contributor

In the same line, I would like to say that I found important differences in the result when naming the boosting parameters with the prefix "bst:". What's wrong with that? I also tried to add a parameter with a mistake and no error was returned...

@tqchen
Copy link
Member

tqchen commented Feb 18, 2016

@ivallesp bst prefix is deprecated in the newest version. If you find it anywhere in the doc, please point it out and send a PR to fix it. Thanks so much

@tqchen tqchen closed this as completed Mar 23, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants