[jvm-packages] Fix json4s binary compatibility issue #7376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spark 3.2 depends on 3.7.0-M11 which has changed some implicited functions' signatures. And it will result the xgboost4j built against spark 3.0/3.1 failed when saving the model.
trivialfis
reviewed
Oct 28, 2021
| @@ -87,3 +89,62 @@ private[spark] object DefaultXGBoostParamsWriter { | |||
| metadataJson | |||
| } | |||
| } | |||
|
|
|||
| // Fix json4s bin-incompatible issue. | |||
There was a problem hiding this comment.
Considering this is some sort of workaround, could you please add a note on when can it be removed in the future?
There was a problem hiding this comment.
It's not a workaround. This PR explicitly call the implicit functions (copied from original Json4s) to build Json object, so the function signatures are unique, and it will not depend on any Json4s version
trivialfis
approved these changes
Oct 29, 2021
trivialfis
pushed a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 10, 2021
Spark 3.2 depends on 3.7.0-M11 which has changed some implicited functions' signatures. And it will result the xgboost4j built against spark 3.0/3.1 failed when saving the model.
trivialfis
added a commit
that referenced
this pull request
Nov 10, 2021
Spark 3.2 depends on 3.7.0-M11 which has changed some implicited functions' signatures. And it will result the xgboost4j built against spark 3.0/3.1 failed when saving the model. Co-authored-by: Bobby Wang <wbo4958@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark 3.2 depends on 3.7.0-M11 which has changed some implicited functions'
signatures. And it will result the xgboost4j built against spark 3.0/3.1
failed when saving the model.